chore: fix rpc consensus_state height_vote_set

[albttx]

It seems there is an error on amino parsing RoundStateSimple.Votes

Before

{
  "jsonrpc": "2.0",
  "id": "",
  "result": {
    "round_state": {
      "height/round/step": "810255/0/1",
      "start_time": "2024-08-14T10:48:40.822715298Z",
      "proposal_block_hash": null,
      "locked_block_hash": null,
      "valid_block_hash": null,
      "height_vote_set": {}
    }
  }
}

After

{
  "jsonrpc": "2.0",
  "id": "",
  "result": {
    "round_state": {
      "height/round/step": "87/0/4",
      "start_time": "2024-08-14T10:46:41.086066222Z",
      "proposal_block_hash": "RzxP5+qPE3m2TmSIPToKlXZSQrsbPpZaVDHBipWceTs=",
      "locked_block_hash": null,
      "valid_block_hash": null,
      "height_vote_set": [
        {
          "round": "0",
          "prevotes": [
            "Vote{0:0E33DB6910E5 87/00/1(Prevote) 473C4FE7EA8F D1B277E50809 @ 2024-08-14T10:46:41.115790322Z}",
            "Vote{1:102A3FB16690 87/00/1(Prevote) 473C4FE7EA8F 05871AA71823 @ 2024-08-14T10:46:41.010870819Z}",
            "nil-Vote"
          ],
          "prevotes_bit_array": "BA{3:xx_} 2/3 = 0.67",
          "precommits": [
            "nil-Vote",
            "nil-Vote",
            "nil-Vote"
          ],
          "precommits_bit_array": "BA{3:___} 0/3 = 0.00"
        },
        {
          "round": "1",
          "prevotes": [
            "nil-Vote",
            "nil-Vote",
            "nil-Vote"
          ],
          "prevotes_bit_array": "BA{3:___} 0/3 = 0.00",
          "precommits": [
            "nil-Vote",
            "nil-Vote",
            "nil-Vote"
          ],
          "precommits_bit_array": "BA{3:___} 0/3 = 0.00"
        }
      ]
    }
  }

After the fix, i realized that tendermint1 latest version is using json too on this field

https://github.com/tendermint/tendermint/blob/35581cf54ec436b8c37fabb43fdaa3f48339a170/rpc/jsonrpc/types/types.go#L187-L200

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.15%. Comparing base (c606efe) to head (d6f4813).
Report is 70 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2696      +/-   ##
==========================================
- Coverage   60.15%   60.15%   -0.01%     
==========================================
  Files         561      561              
  Lines       74999    74999              
==========================================
- Hits        45119    45112       -7     
- Misses      26505    26509       +4     
- Partials     3375     3378       +3     

Flag	Coverage Δ
contribs/gnodev	60.58% <ø> (-0.82%)	⬇️
contribs/gnofaucet	14.46% <ø> (-0.86%)	⬇️
gnovm	64.13% <ø> (ø)
misc/genstd	80.54% <ø> (ø)
misc/logos	20.23% <ø> (+0.35%)	⬆️
tm2	62.03% <100.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zivkovicmilos]

Can we figure out why the Amino JSON is causing an empty object? What is the type of res?
Maybe we just need to register the package / type with Amino

It's now causing tests to fail, most likely because we use Amino JSON to unmarshal all responses / requests

[thehowl]

This has to be fixed by implementing MarshalAmino where necessary, so that amino.MarshalJSON works correctly.

I'm closing this PR and opening up an issue. I'd do this myself, but I'd want to make sure this is done for all current implementations of json.Marshaler and that the work is thorough, so this is non-trivial.

See #2882.