feat: implement an estimate gas method #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gnolang/gno#1826 PR should be the first to be merged. |
jinoosss
force-pushed
the
feat/implement-an-estimage-gas-method
branch
from
e1ffd83 to
9e45d2c
Compare
zivkovicmilos
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Works great 👏 👏 👏
A giant leap in UX 🙏
One idea we can improve is how the Tx lifecycle is implemented. Right now we have methods that (in 1):
- create a tx
- sign the tx
- broadcast the tx
when in reality these should be separate, and allow the user to modify bits and pieces they want; but this is for a future PR 🫡
zivkovicmilos
added a commit
to gnolang/gno
that referenced
this pull request
Jan 14, 2025
## Description Closes #1826 along with gnolang/tm2-js-client#192 This PR introduces a method `EstimateGas` to estimate the gas used by a transaction in gnoclient. We can use this call to get a ballpark estimate if a transaction succeeds, and if it does, how much gas it actually used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions
Retrieve the estimated
GasUsedby calling the simulate method of the ABCI query.Send transaction data through the
.app/simulatepath to the ABCI query to extractGasUsedinformation from the executed result.Related Issue
apppath method to simulate for ABCI query gno#3207