Feature: Ephemeral action runners #33570
Conversation
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/api
|
Possible needs investigation, once gitea has returned a job to act_runner and it starts executing this door is closed |
| const deleteEphemeralRunnerBatchSize = 100 | ||
|
|
||
| // CleanupEphemeralRunners removes used ephemeral runners which are no longer able to process jobs | ||
| func CleanupEphemeralRunners(ctx context.Context) error { |
There was a problem hiding this comment.
I also think about to remove offline EphemeralRunners here that didn't connect within 24h as auto cleanup.
We currently cannot remove runners via api.
| Ephemeral bool `xorm:"ephemeral"` | ||
| } | ||
|
|
||
| return x.Sync(new(ActionRunner)) |
There was a problem hiding this comment.
It's better to update the legacy data as false rather than null.
There was a problem hiding this comment.
I wonder if you mean something like that
| return x.Sync(new(ActionRunner)) | |
| if err := x.Sync(new(ActionRunner)); err != nil { | |
| return err | |
| } | |
| // update all records to set ephemeral to false | |
| _, err := x.Exec("UPDATE `action_runner` SET `ephemeral` = false WHERE `ephemeral` IS NULL") | |
| return err |
Or adding a xorm tag like this for both migration and model (I'm not 100% sure, no examples in Gitea has both name and the not null sequence)
Ephemeral bool `xorm:"ephemeral NOT NULL DEFAULT false"`
Closes #32461