Small refactor to reduce unnecessary database queries and remove duplicated functions #33779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
delvh
approved these changes
Mar 3, 2025
GiteaBot
added
lgtm/need 1
metiftikci
reviewed
Mar 3, 2025
| @@ -43,15 +43,12 @@ func init() { | |||
| // GetSchedulesMapByIDs returns the schedules by given id slice. | |||
| func GetSchedulesMapByIDs(ctx context.Context, ids []int64) (map[int64]*ActionSchedule, error) { | |||
| schedules := make(map[int64]*ActionSchedule, len(ids)) | |||
| if len(ids) == 0 { | |||
There was a problem hiding this comment.
I'm not sure if this is a good approach to allow calling functions with empty array. I guess we should not? 🤔
There was a problem hiding this comment.
Maybe some places have checked that but I think the duplicated checking will not cost too much but reducing possible database queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.