Follow clippy 1.84; limit NodePath::subpath() polyfill again
#1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
quality-of-life
Bromeon
changed the title
NodePath::subpath() polyfill againNodePath::subpath() polyfill again
Now that upstream bug is fixed, we can limit the polyfill to 4.3.
Bromeon
force-pushed
the
qol/nodepath-subpath-clippy
branch
from
db11977 to
a23bf9f
Compare
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1010 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original
NodePathPR #982 added a workaround for a Godot bug, which interpreted indices wrong.Now that upstream godotengine/godot#100954 has been merged, we can limit that polyfill to Godot version 4.3.
Also follows suit with new clippy lints from Rust 1.84.