Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare scripts via object_id #1036

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Compare scripts via object_id #1036

merged 1 commit into from
Feb 8, 2025

Conversation

TitanNano
Copy link
Contributor

Follow up for #1013 that adds SAFETY comment to unsafe block and uses object_id() for script object comparison.

@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1036

@Bromeon Bromeon added quality-of-life No new functionality, but improves ergonomics/internals c: core Core components labels Feb 5, 2025
Bromeon
Bromeon reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Bromeon Bromeon added this pull request to the merge queue Feb 8, 2025
@Bromeon
Copy link
Member

Bromeon commented Feb 8, 2025

Thank you!

Merged via the queue into godot-rust:master with commit 7dad97c Feb 8, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bromeon Bromeon Bromeon left review comments

Assignees
No one assigned
Labels
c: core Core components quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TitanNano @GodotRust @Bromeon