Handle panics in virtual interface methods #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
bug
c: register
Bromeon
force-pushed
the
bugfix/virtual-call-panics
branch
from
4f6b0b1 to
e37ff77
Compare
Bromeon
force-pushed
the
bugfix/virtual-call-panics
branch
from
e37ff77 to
5a989fe
Compare
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-757 |
Since there is no way to check for errors on the call site in the case of ptrcalls, such entries could never be removed. If in the future there is an automatic removal, this could be re-enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catches panics occurring in virtual calls.
Fixes #422.
Due to a lack of error reporting in Godot's virtual call mechanism, we cannot transport the errors to the user, neither as panics nor as
CallErrorinObject::try_call(). If this is desired, we might want to work out a specific design for it in the future.