Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document why Basis columns are a, b, and c #776

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

fpdotmonkey
Copy link
Contributor

Why Basis doesn't follow Godot's column name convention came up in Discord, and the reasoning was fairly buried in code reviews and commits in other projects, so I'm sharing the knowledge with API users.

The explanation here is lifted directly from godot-rust/gdnative@16aa18e

@Bromeon Bromeon added documentation Improvements or additions to documentation c: core Core components labels Jun 23, 2024
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-776

@Bromeon
Copy link
Member

Bromeon commented Jun 23, 2024

Thanks a lot, this is worded much better than I could have 💪

Maybe we could also mention this for the transform types? Not copy-paste but link to the Basis explanation...

Why Basis doesn't follow Godot's column name convention came up in
Discord, and the reasoning was fairly buried in code reviews and commits
in other projects, so I'm sharing the knowledge with API users.

The explanation here is lifted directly from
godot-rust/gdnative@16aa18e
@fpdotmonkey fpdotmonkey force-pushed the document-basis-a-b-c branch from 7a6fdfe to 58fb2a5 Compare June 23, 2024 14:12
@fpdotmonkey
Copy link
Contributor Author

Thanks a lot, this is worded much better than I could have 💪

Appreciate it, though it's mostly copy-pasted from a commit you wrote. Anyway, made changes to the Transforms.

@Bromeon Bromeon added this pull request to the merge queue Jun 26, 2024
Merged via the queue into godot-rust:master with commit 26ef0dc Jun 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: core Core components documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants