Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation for api-* mutual exclusivity #809

Merged
merged 3 commits into from
Jul 27, 2024

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Jul 22, 2024

Turns out this was already disallowed, because prebuilt imports would lead to conflicts.

Anyway, I've improved the error messages, and also fixed a #[cfg(before_api = "4.3")] warning because the corresponding cfg wasn't emitted in the godot crate.

@Bromeon Bromeon added bug c: tooling CI, automation, tools labels Jul 22, 2024
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-809

@Bromeon Bromeon added this pull request to the merge queue Jul 22, 2024
@Bromeon Bromeon removed this pull request from the merge queue due to a manual request Jul 22, 2024
@Bromeon Bromeon force-pushed the bugfix/api-exclusivity-check branch from 3261dea to 53b911f Compare July 23, 2024 17:04
@Bromeon Bromeon force-pushed the bugfix/api-exclusivity-check branch from 53b911f to a267495 Compare July 27, 2024 13:36
@Bromeon Bromeon added quality-of-life No new functionality, but improves ergonomics/internals and removed bug labels Jul 27, 2024
@Bromeon Bromeon enabled auto-merge July 27, 2024 13:39
@Bromeon Bromeon added this pull request to the merge queue Jul 27, 2024
Merged via the queue into master with commit 01678e5 Jul 27, 2024
15 checks passed
@Bromeon Bromeon deleted the bugfix/api-exclusivity-check branch July 27, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: tooling CI, automation, tools quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants