Fix user-after-free in AsObjectArg pass-by-value (in default-param methods)
#846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
bug
c: engine
Bromeon
changed the title
AsObjectArg pass-by-value (in default-param methods)
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-846 |
Bromeon
force-pushed
the
bugfix/object-arg-values
branch
from
797d485 to
0315266
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #835.
No longer causes UB when passing objects by value to engine methods that have default parameters.
Notably, this PR does not enforce borrowing/taking by reference (at least for now).