Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompositorEffect Function _render_callback Doesn't Do Anything #1685

Closed
The-Raphie opened this issue Jan 13, 2025 · 3 comments
Closed

CompositorEffect Function _render_callback Doesn't Do Anything #1685

The-Raphie opened this issue Jan 13, 2025 · 3 comments

Comments

@The-Raphie
Copy link

Godot version

v4.3.stable.official [77dcf97d8]

godot-cpp version

4.3.stable

System information

Operating System: EndeavourOS KDE Plasma Version: 6.2.1 KDE Frameworks Version: 6.7.0 Qt Version: 6.8.0 Kernel Version: 6.11.4-arch1-1 (64-bit) Graphics Platform: X11 Processors: 12 × Intel® Core™ i7-10750H CPU @ 2.60GHz Memory: 15.4 GiB of RAM Graphics Processor: NVIDIA GeForce GTX 1660 Ti/PCIe/SSE2 Manufacturer: ASUSTeK COMPUTER INC. Product Name: ROG Zephyrus M15 GU502LU_GU502LU System Version: 1.0

Issue description

When dealing with the CompositerEffect resource, the function _render_callback, which should run every frame, doesn't run at all.

Steps to reproduce

  1. Open the minimal reproduction project with Godot 4.3.
  2. If the output is not printing the word "Test" repeatedly, then the _render_callback function in GDExtension is not working correctly.

Minimal reproduction project

https://drive.google.com/file/d/1upEw41XvzIDORykg_GxgHs2nBk1jDFLt/view?usp=sharing

Github wouldn't let me upload the .zip directly.

@dsnopek
Copy link
Collaborator

dsnopek commented Jan 14, 2025

Thanks!

This should be fixed by PR godotengine/godot#99981 which will be included in Godot 4.4

@dsnopek dsnopek closed this as completed Jan 14, 2025
@The-Raphie
Copy link
Author

@dsnopek Is there any workaround for the time being while 4.3 is the latest stable version?

@dsnopek
Copy link
Collaborator

dsnopek commented Jan 14, 2025

Hm, you could maybe use GDScript to work around it: add a normal method to your C++ class, and then attach a GDScript to it that implements _render_callback to call that method?

Or, alternatively, you could take the Godot 4.3 source and just apply the changes from PR godotengine/godot#99981 and re-compile Godot, so you'd have a custom version with that bug fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants