CompositorEffect should use GDVIRTUAL_CALL() so it works with GDExtension
#99981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
changed the title
CompositorEffect should use GDVIRTUAL_CALL() so it works with GDExtensionCompositorEffect should use GDVIRTUAL_CALL() so it works with GDExtension
|
I tested this PR with the demo project here: https://github.com/godotengine/godot-demo-projects/tree/master/compute/post_shader Everything seems to be working, so taking this out of draft! |
dsnopek
added
the
cherrypick:4.3
Bromeon
approved these changes
Dec 11, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Virtual methods defined with
GDVIRTUAL*()should always useGDVIRTUAL_CALL()to call them, so that they work via both GDExtension and GDScript.Presently,
CompositorEffectis using a trick withCallable()that only works with GDScript, and this PR switches to usingGDVIRTUAL_CALL().This is marked as DRAFT because I haven't actually tested it yet. I've never used compositor effects, so I need to get a test project going, but then I'll mark it as ready for review.Fixes #99933