Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix allocation size overflow check in CowData #1245

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix allocation size overflow check in CowData #1245

merged 1 commit into from
Sep 20, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips added bug This has been identified as a bug crash cherrypick:4.1 labels Sep 20, 2023
@AThousandShips AThousandShips added this to the 4.2 milestone Sep 20, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner September 20, 2023 11:18
dsnopek
dsnopek approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The patch looks identical to what was just merged in Godot

@dsnopek dsnopek merged commit a3dfbbd into godotengine:master Sep 20, 2023
@AThousandShips AThousandShips deleted the alloc_fix branch September 20, 2023 12:44
@AThousandShips
Copy link
Member Author

Thank you!

@dsnopek
Copy link
Collaborator

dsnopek commented Oct 9, 2023

Cherry-picked for 4.1 in PR #1261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
bug This has been identified as a bug crash
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@AThousandShips @dsnopek