Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix physics picking in Gui in 3D Demo #1139

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

Sauermann
Copy link
Contributor

Physics picking requires that the SubViewport has a consistent state of the mouse-enter/exit notifications.

Godot V4.3 was changed in comparison to V4.2, so that it now requires this additional step.

While this demo is focused on Control nodes, Physics picking should also work, since the demo project is used sometimes as a baseline for physics interactions (for example on the forum).

Physics picking requires that the SubViewport has a consistent state
of the mouse-enter/exit notifications.

Godot V4.3 was changed in comparison to V4.2, so that it now requires
this additional step.
Co-authored-by: Aaron Franke <arnfranke@yahoo.com>
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on 4.3, it works as expected.

Thanks!

@Calinou Calinou merged commit 6f44371 into godotengine:master Nov 25, 2024
1 check passed
@Calinou Calinou mentioned this pull request Nov 25, 2024
@Sauermann Sauermann deleted the fix-viewport-mouse branch November 25, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants