Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spring arm third-person camera tutorial #10156

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

TranquilMarmot
Copy link
Contributor

Closes #4126

@AThousandShips AThousandShips added enhancement content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:3d labels Oct 28, 2024
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

I followed along with the step by step tutorial that uses the Platformer 3D demo as a base, and following the directions as-is leads to a compile error and non-working code. It needs a few changes.

The rest is great. Good work on the graphics!

@TranquilMarmot
Copy link
Contributor Author

@tetrapod00 thanks so much for the in-depth review! I think I handled all of your comments.

Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more set of code style nitpicks, then this looks good to me.

Co-authored-by: tetrapod <145553014+tetrapod00@users.noreply.github.com>
rotates around something such as a player character or a vehicle.

In Godot, this can be done by setting a :ref:`Camera3D <class_Camera3D>` as a child of a node.
However, if you try this without any extra steps you'll notice that the camera clips through geometry and hides the scene.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
However, if you try this without any extra steps you'll notice that the camera clips through geometry and hides the scene.
However, if you try this without any extra steps, you'll notice that the camera clips through geometry and hides the scene.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in e954194.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit ffb7983 into godotengine:master Nov 4, 2024
1 check passed
@tetrapod00
Copy link
Contributor

I made the PR for class ref tutorial link: godotengine/godot#98828

@TranquilMarmot TranquilMarmot deleted the spring-arm-tutorial branch November 5, 2024 06:08
@tetrapod00 tetrapod00 mentioned this pull request Nov 6, 2024
mhilbrunner pushed a commit that referenced this pull request Nov 30, 2024
Co-authored-by: tetrapod <145553014+tetrapod00@users.noreply.github.com>
@mhilbrunner
Copy link
Member

Cherrypicked to 4.3 in #10346.

sshiiden pushed a commit to blazium-engine/blazium-docs that referenced this pull request Mar 29, 2025
Co-authored-by: tetrapod <145553014+tetrapod00@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features enhancement topic:3d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document clipped and spring arm camera in 3D
5 participants