-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spring arm third-person camera tutorial #10156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
I followed along with the step by step tutorial that uses the Platformer 3D demo as a base, and following the directions as-is leads to a compile error and non-working code. It needs a few changes.
The rest is great. Good work on the graphics!
74031cf
to
4d3a11a
Compare
@tetrapod00 thanks so much for the in-depth review! I think I handled all of your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more set of code style nitpicks, then this looks good to me.
4d3a11a
to
6692ecb
Compare
Co-authored-by: tetrapod <145553014+tetrapod00@users.noreply.github.com>
6692ecb
to
8fa8ad0
Compare
rotates around something such as a player character or a vehicle. | ||
|
||
In Godot, this can be done by setting a :ref:`Camera3D <class_Camera3D>` as a child of a node. | ||
However, if you try this without any extra steps you'll notice that the camera clips through geometry and hides the scene. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, if you try this without any extra steps you'll notice that the camera clips through geometry and hides the scene. | |
However, if you try this without any extra steps, you'll notice that the camera clips through geometry and hides the scene. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in e954194.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I made the PR for class ref tutorial link: godotengine/godot#98828 |
Co-authored-by: tetrapod <145553014+tetrapod00@users.noreply.github.com>
Cherrypicked to 4.3 in #10346. |
Co-authored-by: tetrapod <145553014+tetrapod00@users.noreply.github.com>
Closes #4126