C# signal delegates must be public

[paulloz]

This is the largest doc edit you'll ever see 👀

[raulsntos]

I think we should actually generate the event with the same accessibility as the delegate, although I'm not sure if there are use cases for non-public signals.

[paulloz]

Does it make sense, given that whatever the event accessibility is, the signal itself is always publicly accessible through the API?
Edit: To be honest, that's essentially true for all methods and property we pick up with source generation, but IDK why it feels different with signals/events 🤔

[raulsntos]

Yeah, that's also true for Get/Set/Call/... The way I see those methods they are like reflection, if you use them you are opting out of the type safety and accessibility guarantees. Just like reflection, they are useful in some scenarios (e.g. GDScript interop) but otherwise I wouldn't recommend using them.

Signals are a bit different because we currently don't have a type safe alternative to EmitSignal, but I'd like to add one (see godotengine/godot#68233).

[paulloz]

Signals are a bit different because we currently don't have a type safe alternative to EmitSignal, but I'd like to add one (see godotengine/godot#68233).

We'd still have to use .Connect for specific cases (e.g. making a connection with ConnectFlags.OneShot).

[raulsntos]

Isn't that the same as await ToSignal? Although that will also work with non-public signals.

[raulsntos]

Anyway, I'm OK with this change since it's true that the restriction exists right now and can't guarantee it'd be lifted for 4.0.

[mhilbrunner]

Thanks!