-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First 3d game animation fixes #8772
Merged
skyace65
merged 7 commits into
godotengine:master
from
docrinehart:first-3d-game-animation-fixes
Feb 2, 2024
Merged
First 3d game animation fixes #8772
skyace65
merged 7 commits into
godotengine:master
from
docrinehart:first-3d-game-animation-fixes
Feb 2, 2024
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
In Godot 4.2.1.stable, the icons are represented by squares instead of diamonds.
Please convert the image to the |
skyace65
requested changes
Jan 17, 2024
skyace65
approved these changes
Jan 24, 2024
Thanks! And congrats on your first merged PR! |
Thank you! Glad I was able to contribute. Hopefully I'll find some time to get in the weeds for the engine itself and make some contributions there. |
mhilbrunner
pushed a commit
that referenced
this pull request
Jul 24, 2024
First 3d game animation fixes (cherry picked from commit c42e54b)
Cherry-picked to 4.2 in #9648. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:getting started
Issues and PRs related to the Getting Started section of the documentation
enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to replace screenshots and add a minor warning regarding the node target for keyframes in the Godot First 3D Game tutorial. -- Relates to comment on issue: #6744
I put in the warning the best explanation I could as far as I understood the issue I had. I'd love to see a more specific or precise explanation added for those learning new concepts.