Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First 3d game animation fixes #8772

Merged

Conversation

docrinehart
Copy link
Contributor

@docrinehart docrinehart commented Jan 15, 2024

This PR aims to replace screenshots and add a minor warning regarding the node target for keyframes in the Godot First 3D Game tutorial. -- Relates to comment on issue: #6744

While the guide correctly states to get animation keyframes from the Character node, all the subsequent screenshots that show the animation panel have Player showing as the target node. This threw me off for a good 40 minutes until I came across a reddit answer highlighting that the root Player shouldn't be used for keyframes. The issue this causes is that the player character is animated and floating, but no longer moves to player input.

I put in the warning the best explanation I could as far as I understood the issue I had. I'd love to see a more specific or precise explanation added for those learning new concepts.

Verified

This commit was created on github.com and signed with GitHub’s verified signature.

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
In Godot 4.2.1.stable, the icons are represented by squares instead of diamonds.
@AThousandShips
Copy link
Member

Please convert the image to the .webp format.
you can read more about it in the Doc image guidelines.

@AThousandShips AThousandShips requested a review from a team January 15, 2024 09:54
@skyace65 skyace65 added enhancement needs work Needs additional work by the original author, someone else or in another repo. area:getting started Issues and PRs related to the Getting Started section of the documentation cherrypick:4.2 labels Jan 15, 2024
@AThousandShips AThousandShips removed the needs work Needs additional work by the original author, someone else or in another repo. label Jan 15, 2024
@docrinehart docrinehart requested a review from skyace65 January 23, 2024 03:15
@skyace65 skyace65 merged commit c42e54b into godotengine:master Feb 2, 2024
@skyace65
Copy link
Contributor

skyace65 commented Feb 2, 2024

Thanks! And congrats on your first merged PR!

@docrinehart
Copy link
Contributor Author

Thanks! And congrats on your first merged PR!

Thank you! Glad I was able to contribute. Hopefully I'll find some time to get in the weeds for the engine itself and make some contributions there.

mhilbrunner pushed a commit that referenced this pull request Jul 24, 2024
First 3d game animation fixes

(cherry picked from commit c42e54b)
@mhilbrunner
Copy link
Member

Cherry-picked to 4.2 in #9648.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:getting started Issues and PRs related to the Getting Started section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants