Add note for hosting asset icons on GitHub #9125
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The asset submission validator will reject a url that ends with a query string such as `?raw=1`. Providing the icon url without the query string passes validation but the image will not load causing: ``` This asset has been rejected. Reason: The icon link must be a direct link. For icons hosted on GitHub, the link must start with "raw.githubusercontent.com", not "github.com". See this article for more information: https://docs.godotengine.org/en/latest/community/asset_library/submitting_to_assetlib.html ``` The required information is listed as a note under Requirements rather than under the relevant Icon section where it is pertinent..
mhilbrunner
reviewed
Mar 24, 2024
mhilbrunner
added
enhancement
area:community
Co-authored-by: Max Hilbrunner <mhilbrunner@users.noreply.github.com>
mhilbrunner
approved these changes
Mar 25, 2024
|
Merged. Thanks and congrats on your first merged contribution! 🎉 |
mhilbrunner
pushed a commit
that referenced
this pull request
Jul 24, 2024
* Add note for hosting asset icons on GitHub --------- Co-authored-by: Max Hilbrunner <mhilbrunner@users.noreply.github.com> (cherry picked from commit 1c09d6a)
|
Cherry-picked to 4.2 in #9648. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The asset submission validator will reject a url that ends with a query string such as
?raw=1. Providing the icon url without the query string passes validation but the image will not load causing:The required information is listed as a note under Requirements rather than under the relevant Icon section where it is pertinent..