Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

classref: Sync with current master branch (1bd740d) #9768

Merged
merged 1 commit into from
Aug 23, 2024
Merged

classref: Sync with current master branch (1bd740d) #9768

merged 1 commit into from
Aug 23, 2024

Conversation

github-actions[bot]
Copy link

Update Godot API online class reference to match the engine at godotengine/godot@1bd740d (master).

@github-actions github-actions bot added area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository bug enhancement labels Aug 17, 2024
@mhilbrunner mhilbrunner marked this pull request as draft August 17, 2024 12:34
@mhilbrunner
Copy link
Member

Note: there are quite a bit of deletions in here we should investigate before merging

AThousandShips
AThousandShips approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see any issues, the changes are largely typo fixes and adjustmens

classes/class_resourceimporterobj.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From godotengine/godot#94100

classes/class_polygon2d.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From godotengine/godot#95376

classes/class_viewport.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No deletions just adjustments for spacing

@mhilbrunner mhilbrunner marked this pull request as ready for review August 17, 2024 16:38
@mhilbrunner
Copy link
Member

Ah, I didn't necessarily mean issues, but for example godotengine/godot#94100 removes a (unused) API, same for godotengine/godot#95376.

In both case, I'm not sure whether they'll get backported to 4.3.x, thus this PR marks master and stable/4.3 diverging.

@mhilbrunner mhilbrunner added this to the 4.4 milestone Aug 17, 2024
@mhilbrunner mhilbrunner merged commit 6950a91 into master Aug 23, 2024
@mhilbrunner mhilbrunner deleted the classref/sync-1bd740d branch August 23, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository bug enhancement
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@mhilbrunner @AThousandShips