-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Examples for export suffix hint feature in GDScript and C# #9785
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add dots at the ends of paragraphs for consistency with the rest of docs. Other than that looks great, I personally didn't know the unit hints exist ;)
According to the workflow you should also squash the commits before merging.
@0stam Good spot😄! thanks I have pushed an update, will squash the commits too |
You may also want to mention that vector types are supported. No need to list every type, but at least Quick testing on which types can be used with this property hint:
Using any unit hint at all is nonsensical for some of these types - for example the transforms or quaternions. Possibly some of these behaviors should be changed on the engine side. |
@tetrapod00 Thank you for your awesome suggestions 👍🏻 and for taking the time to test the values! 🙌🏻. I've gone ahead and added your suggestions🎉. |
Co-authored-by: tetrapod <145553014+tetrapod00@users.noreply.github.com>
|
||
.. code-block:: csharp | ||
|
||
[Export(PropertyHint.None,"suffix:m/s\u00b2")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this again, using \u00b2
for the squared symbol may merit a comment or a mention in the preceding sentence. Personally I think it's fine as is - curiosity is a good teacher.
Other than that, LGTM but my approval as just a contributor is not the one that matters for getting these changes merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tetrapod00 thanks for the feedback!
I agree that it's probably a good idea to add a comment / clarification regarding the use of \u00b2
, I'll wait for input from maintainers to see how they'd like to proceed.
Think this PR will need some guidance from the maintainers regarding if the placement of the examples for export suffix hint in the page are alright. Additionally some guidance in relation to @tetrapod00's comment would be helpful to determine if there are any missing explanations or additional examples should be included. |
|
In response to the discussion in godot-proposals #10498, this pull request updates the documentation to surface this functionality