Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removing files from Search Results #7881

Closed
KoBeWi opened this issue Sep 26, 2023 · 3 comments · Fixed by godotengine/godot#101472
Closed

Allow removing files from Search Results #7881

KoBeWi opened this issue Sep 26, 2023 · 3 comments · Fixed by godotengine/godot#101472

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Sep 26, 2023

Describe the project you are working on

Some big projects with lots of code etc.

Describe the problem or limitation you are having in your project

I sometimes do full code search inside Godot to find occurrences of something and perform some work. The problem is that sometimes I get results I'm not interested in or I finished doing something in a file and I don't need it anymore. Unfortunately, the only thing I can do about such files is to fold them:
image
It becomes unwieldy as the list of folded stuff grows and gets in my way.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

In VS Code there is an option to remove a result from the list of found items:

Code_0y2yOkGRdb.mp4

You can remove single elements or whole files. Having this in Godot would be useful, even if only for removing files.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

In search results there would be a button next to each file/element that allows to delete it:
image
If we add it only for files, it can be always visible. If for every element, it should likely show only on hover, like in VS Code.

If this enhancement will not be used often, can it be worked around with a few lines of script?

Everything is possible with enough hacking.
Not sure if it's few lines in this case.

Is there a reason why this should be core and not an add-on in the asset library?

It improves usability of integral editor feature.

@Ymanawat
Copy link

Ymanawat commented Sep 29, 2023

I want to add a thing: making this searched word label a text edit. This allows us to quickly search for another word if needed. On refreshing, files with the new searched word will appear.
In the place of red line in here:
Screenshot 2023-09-30 005632

We can also make the replace bar below with find, so we don't need to go again and select to find and all.

@Calinou
Copy link
Member

Calinou commented Oct 4, 2023

@Ymanawat Please open a separate proposal so this can be tracked independently 🙂

@EricEzaM
Copy link

EricEzaM commented Dec 8, 2023

See also #5544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants