Add the ability to remove files when using file search #82621
Closed
+30
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stronkkey
changed the title
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
| void _on_finished(); | ||
| void _on_refresh_button_clicked(); | ||
| void _on_cancel_button_clicked(); | ||
| void _on_result_selected(); | ||
| void _on_item_edited(); | ||
| void _on_replace_text_changed(String text); | ||
| void _on_replace_all_clicked(); | ||
| Texture2D* _get_remove_button_texture(); |
There was a problem hiding this comment.
Suggested change
| Texture2D* _get_remove_button_texture(); |
| RD::get_singleton()->free(device.passes[i].pipeline.pipeline_rid); | ||
| if (device.passes[i].pipeline.pipeline_rid.is_valid()) { | ||
| RD::get_singleton()->free(device.passes[i].pipeline.pipeline_rid); | ||
| } |
There was a problem hiding this comment.
You still have unrelated code, and another author not part of this, you will need to remove this code and reset the author of your commit with git commit --reset-author
|
I messed up my commit history by syncing the repo. Will be reopened soon. |
|
I mean I'll make a new clean pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements godot-proposals#7881