Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make warnings/notes in build scripts colored #9291

Closed
dustdfg opened this issue Mar 12, 2024 · 2 comments · Fixed by godotengine/godot#91220
Closed

Make warnings/notes in build scripts colored #9291

dustdfg opened this issue Mar 12, 2024 · 2 comments · Fixed by godotengine/godot#91220
Milestone

Comments

@dustdfg
Copy link

dustdfg commented Mar 12, 2024

Describe the project you are working on

Just build custom export template and try master branch

Describe the problem or limitation you are having in your project

The build process shows me blue text (when it compiles files) but the warnings have the same white colors as any other text

Describe the feature / enhancement and how it helps to overcome the problem or limitation

When you see a bunch of white text for especially when you enable SCU you can't notice if there was any warning because it scrolls out too quickly. If I saw a yellow color between white I would notice it...

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Use not just print("Note: Using execinfo=yes for the crash handler as required on platforms where glibc is missing.") but something like it at least in linux specific script

If this enhancement will not be used often, can it be worked around with a few lines of script?

It is for those who enter godot building or just want custom export template so it won't be used much but can't be worked around

Is there a reason why this should be core and not an add-on in the asset library?

It is a part of the build system

@Calinou Calinou changed the title Meke warnings/notes in build scripts colored Make warnings/notes in build scripts colored Mar 12, 2024
@Calinou
Copy link
Member

Calinou commented Mar 12, 2024

Regarding the SCU build text (which I also found to be intrusive over time), I think we could simplify it so it takes fewer lines. We could display something like "SCU: Merging N files into 1 file.") and possibly display it in gray as well.

We should keep some kind of print for it as using SCU builds can hide real errors, but it can be made shorter.

Edit: Done in godotengine/godot#89483.

@akien-mga akien-mga added this to the 4.3 milestone Apr 29, 2024
@akien-mga
Copy link
Member

Implemented by godotengine/godot#91220.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants