Add colors to SCons error/warning messages #88074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
scons-add-colored-warnings-errors
branch
5 times, most recently
from
772d35b to
37cef60
Compare
Calinou
force-pushed
the
scons-add-colored-warnings-errors
branch
from
37cef60 to
0fcefaf
Compare
This also includes various improvements to the messages: - Remove some "success" messages that were printed on every build, such as the macOS minimum supported version (which is already mentioned in the documentation). Only the "error" variants of these messages are kept. - Use gray color for the build timer printed at the end of each build, and only display 2 decimals. - Use non-zero exit codes when exiting after some error messages that previously exited with a zero (success) exit code. - Improve formatting of the Direct3D 12 missing dependencies message. - Clarify how MSVC is detected in the message printed when it's detected. - Force colored output on CI (it's non-interactive but can still display colors).
Calinou
force-pushed
the
scons-add-colored-warnings-errors
branch
from
0fcefaf to
8064491
Compare
akien-mga
reviewed
Mar 13, 2024
| + get_ndk_version() | ||
| + " manually." | ||
| ) | ||
| sys.exit() | ||
| sys.exit(200) |
There was a problem hiding this comment.
Why 200 here specifically? We seem to use 255 throughout otherwise.
There was a problem hiding this comment.
Ah I see we had this:
platform/windows/detect.py
305: sys.exit(200)
That's the only occurrence, so I'd tend to say it was a mistake and not an intentional error reporting API.
|
Superseded by #91220. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes various improvements to the messages:
Preview
I also had automatic underlining of backticked text at some point, but I removed it for now. Let me know if you'd like me to readd it: