Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[D3D12] Spam of "WARNING: Returning maximum value for unknown limit 12" #100055

Closed
adamscott opened this issue Dec 5, 2024 · 4 comments · Fixed by #100058
Closed

[D3D12] Spam of "WARNING: Returning maximum value for unknown limit 12" #100055

adamscott opened this issue Dec 5, 2024 · 4 comments · Fixed by #100058

Comments

@adamscott
Copy link
Member

Tested versions

  • Reproducible in master
  • Not reproducible in 4.3

System information

Godot v4.4.dev (1f47e4c) - Windows 10.0.22631 - Multi-window, 1 monitor - Direct3D 12 (Forward+) - integrated Microsoft Basic Render Driver (Microsoft; 10.0.22621.2506) - virt-7.2 (12 threads)

Issue description

WARNING: Returning maximum value for unknown limit 12.
     at: RenderingDeviceDriverD3D12::limit_get (drivers\d3d12\rendering_device_driver_d3d12.cpp:6184)

Steps to reproduce

  1. Open Godot
  2. See that the warning is spammed.

Minimal reproduction project (MRP)

n/a

@akien-mga
Copy link
Member

CC @RandomShaper @DarioSamo

@DarioSamo
Copy link
Contributor

DarioSamo commented Dec 5, 2024

16ee2f2 added a check for texture size, but D3D12 driver does not implement the limits it requests. They should be implemented on the driver.

LIMIT_MAX_TEXTURE_SIZE_1D
LIMIT_MAX_TEXTURE_SIZE_2D
LIMIT_MAX_TEXTURE_SIZE_3D
LIMIT_MAX_TEXTURE_SIZE_CUBE

@akien-mga
Copy link
Member

CC @Carbonyte

@DarioSamo
Copy link
Contributor

I'll do a PR implementing the limits properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants