Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add texture limits for D3D12 Driver. #100058

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Add texture limits for D3D12 Driver. #100058

merged 1 commit into from
Dec 5, 2024

Conversation

DarioSamo
Copy link
Contributor

A lot of limits are not implemented in the D3D12 driver. This introduces a few that are now requested as part of texture creation.

Should fix #100055.

@DarioSamo DarioSamo requested a review from a team as a code owner December 5, 2024 16:57
@akien-mga akien-mga added this to the 4.4 milestone Dec 5, 2024
adamscott
adamscott approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the fix. It works! And the code looks alright too.

@Repiteo Repiteo merged commit 85862ea into godotengine:master Dec 5, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 5, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug platform:windows topic:rendering
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

[D3D12] Spam of "WARNING: Returning maximum value for unknown limit 12"
5 participants
@DarioSamo @Repiteo @adamscott @clayjohn @akien-mga