Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScrollContainer focus StyleBox is not clipped by parent #100176

Open
Giganzo opened this issue Dec 8, 2024 · 4 comments · May be fixed by #104317
Open

ScrollContainer focus StyleBox is not clipped by parent #100176

Giganzo opened this issue Dec 8, 2024 · 4 comments · May be fixed by #104317
Labels
bug topic:gui

Comments

@Giganzo
Copy link
Contributor

Giganzo commented Dec 8, 2024 •
edited
Loading

Tested versions

v4.4.dev6.official [1f47e4c]

System information

Fedora Linux 40 (KDE Plasma) on Wayland - X11 display driver, Multi-window

Issue description

Image

PR #97521 added a focus style for ScrollContainer this has the same problem as following issues:

Tree:
#100063
#88749
#74670

ItemList:
#77919

Steps to reproduce

A ScrollContainer inside another ScrollContainer
Add some content to both
Enable draw_focus_border for second ScrollContainer
Select something in the second ScrollContainer so it gets focus
Scroll the first ScrollContainer

Minimal reproduction project (MRP)

scrollfocus.zip
@AThousandShips AThousandShips changed the title ScrollConatiner focus StyleBox is not clipped by parent ScrollContainer focus StyleBox is not clipped by parent Dec 8, 2024
@JekSun97

This comment has been minimized.

Sign in to view
@pafuent
Copy link
Contributor

pafuent commented Dec 19, 2024

I'll try to take a look at it, but finding free time around EoY is really hard for me.

@pafuent
Copy link
Contributor

pafuent commented Dec 23, 2024

Just a small clarification, all the bugs referenced are not related to the change that I implemented. All of them where already present on 4.3
Of course that is not the case for this bug.

@JekSun97
Copy link
Contributor

Just a small clarification, all the bugs referenced are not related to the change that I implemented. All of them where already present on 4.3 Of course that is not the case for this bug.

Indeed, this problem exists since 4.0.

pafuent added a commit to pafuent/godot that referenced this issue Mar 18, 2025
@pafuent
Fix ScrollContainer focus border issue
ab4c855 
Fixes godotengine#100176

Instead of using no clipping technique to draw the focus border because
it causes problems if a `ScrollContainer` is nested in another
`ScrollContainer`, now the focus border is drawn using an internal
`PanelContainer`.
@pafuent pafuent linked a pull request Mar 18, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ScrollContainer focus border issue pafuent/godot
4 participants
@Chaosus @pafuent @JekSun97 @Giganzo