Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CollisionPolygon3D is not visible in the running project when Visible Collision Shapes is enabled in the Debug menu #101413

Closed
Calinou opened this issue Jan 10, 2025 · 4 comments · Fixed by #101810

Comments

@Calinou
Copy link
Member

Calinou commented Jan 10, 2025

Tested versions

  • Reproducible in: 4.4.dev 24d7451
  • Not reproducible in: 4.3.stable

System information

Godot v4.4.dev (24d7451) - Fedora Linux 41 (KDE Plasma) on X11 - X11 display driver, Multi-window, 1 monitor - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4090 (nvidia; 565.77) - 13th Gen Intel(R) Core(TM) i9-13900K (32 threads)

Issue description

CollisionPolygon3D is not visible in the running project when Visible Collision Shapes is enabled in the Debug menu.

4.3.stable

Image

master

Image

master (in the editor)

Image

Steps to reproduce

  • Load the MRP linked below.
  • Enable Debug > Visible Collision Shapes then run the project.
  • Notice how only the sphere collision shape appears, not the collision polygon, despite both being direct children of their respective StaticBody3D.

Minimal reproduction project (MRP)

test_collision_polygon3d.zip

@smix8
Copy link
Contributor

smix8 commented Jan 18, 2025

Does not happen in Godot 4.4 dev5 and started with dev6.

EDIT

Someone did the bisect and is indeed #90644 that caused the regression.

@smix8
Copy link
Contributor

smix8 commented Jan 18, 2025

@BattyBovine if you are available to look into this regression.

@BattyBovine
Copy link
Contributor

This is strange, because I never touched anything specific to CollisionPolygon3D. I'm still going to look into it because I do have to also add the filled shapes to CollisionPolygon3D, and clearly something happened here that I should fix.

@Calinou Calinou moved this from Unassessed to Bad in 4.x Release Blockers Jan 18, 2025
@BattyBovine
Copy link
Contributor

The solution here turned out to be pretty simple. CollisionPolygon3D did not support custom debug colours (#101414), and therefore was rendering its debug lines as Color(0.0, 0.0, 0.0, 0.0), making them invisible. By fixing #101414, we also fix this. I'll get the fix finalised soon.

Splizard pushed a commit to grow-graphics/godot that referenced this issue Feb 2, 2025
This brings CollisionPolygon3D up to feature parity with its counterpart
CollisionShape3D. Closes godotengine#101414.

In addition, adding this feature fixes the issue that CollisionPolygon3D
would never be rendered in exported builds, even if Visible Collision Shapes
is enabled at runtime. Closes godotengine#101413.
tGautot pushed a commit to tGautot/godot that referenced this issue Feb 5, 2025
This brings CollisionPolygon3D up to feature parity with its counterpart
CollisionShape3D. Closes godotengine#101414.

In addition, adding this feature fixes the issue that CollisionPolygon3D
would never be rendered in exported builds, even if Visible Collision Shapes
is enabled at runtime. Closes godotengine#101413.
tGautot pushed a commit to tGautot/godot that referenced this issue Feb 5, 2025
This brings CollisionPolygon3D up to feature parity with its counterpart
CollisionShape3D. Closes godotengine#101414.

In addition, adding this feature fixes the issue that CollisionPolygon3D
would never be rendered in exported builds, even if Visible Collision Shapes
is enabled at runtime. Closes godotengine#101413.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Bad
Development

Successfully merging a pull request may close this issue.

3 participants