Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serious visual regression with NinePatchRect #101672

Closed
Chaosus opened this issue Jan 17, 2025 · 3 comments · Fixed by #101709
Closed

Serious visual regression with NinePatchRect #101672

Chaosus opened this issue Jan 17, 2025 · 3 comments · Fixed by #101709

Comments

@Chaosus
Copy link
Member

Chaosus commented Jan 17, 2025

Tested versions

4.4 beta 1

System information

Windows 11

Issue description

I've detected that NinePatchRect which is valid previously (dev 7):

Image

become blurred in the beta 1:

Image

Steps to reproduce

Run game_dialog.tscn scene in the attached project, the bug is visible either in the game or in the editor.

Minimal reproduction project (MRP)

NprBug.zip

@Chaosus Chaosus added this to the 4.4 milestone Jan 17, 2025
@Chaosus Chaosus moved this from Unassessed to Immediate Blocker in 4.x Release Blockers Jan 17, 2025
@bruvzg
Copy link
Member

bruvzg commented Jan 17, 2025

Seems to be OpenGL specific issue, it's not reproducible with Metal and Vulkan.

@AThousandShips
Copy link
Member

AThousandShips commented Jan 17, 2025

Bisecting Resolved

@bruvzg
Copy link
Member

bruvzg commented Jan 17, 2025

Seems to be regression from #99230, this line in particular, removing it fix the issue:

https://github.com/paddy-exe/godot/blob/4ce466d7fa79e351d4295d5bb47e3266089c3a59/drivers/gles3/rasterizer_canvas_gles3.cpp#L918

cc @paddy-exe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Immediate Blocker
Development

Successfully merging a pull request may close this issue.

4 participants