Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Godot 4.4 beta 1] Regression for the Compatibility Renderer #101699

Closed
xsellier opened this issue Jan 17, 2025 · 3 comments · Fixed by #101709
Closed

[Godot 4.4 beta 1] Regression for the Compatibility Renderer #101699

xsellier opened this issue Jan 17, 2025 · 3 comments · Fixed by #101709

Comments

@xsellier
Copy link
Contributor

Tested versions

  • Not reproducible in Godot dev 5
  • Reproducible in Godot beta 1

I was able to bisect the issue to this commit 1536e0e

System information

Linux binogure 6.11-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.11-1~exp1 (2024-09-19) x86_64 GNU/Linux

Issue description

Using Tile or tile Fit for a panel in a theme leads to glitches in all others 2d textures.

compatibility-renderer-broken.webm

Steps to reproduce

Minimal reproduction project (MRP)

https://github.com/xsellier/godot-4-4-opengl-custom-draw-issue

@clayjohn
Copy link
Member

clayjohn commented Jan 17, 2025

Are you doing any 3D rendering in that scene? 1536e0e only changes shader code in the spatial shader template. I can't see how it would interact with the 2D renderer at all

Testing dev versions it seems that this is a regression between dev 7 and beta 1 and 1536e0e was merged after dev 7 and before beta 1

After some quick Renderdoc debugging, I suspect that #99230 is the actual culprit. I think some of the Ninepatch state is leaking into subsequent draw commands

@clayjohn clayjohn moved this from Unassessed to Very Bad in 4.x Release Blockers Jan 17, 2025
@clayjohn
Copy link
Member

Yep, tracked it down. It was a failed rebase from #99230. It brought back a line of code that was removed earlier in #98835

@xsellier
Copy link
Contributor Author

Thanks, it's fixed indeed !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Very Bad
Development

Successfully merging a pull request may close this issue.

3 participants