Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI Control sizing/positioning initially incorrect #18940

Closed
ibrahn opened this issue May 16, 2018 · 4 comments · Fixed by #19334
Closed

GUI Control sizing/positioning initially incorrect #18940

ibrahn opened this issue May 16, 2018 · 4 comments · Fixed by #19334
Milestone

Comments

@ibrahn
Copy link
Contributor

ibrahn commented May 16, 2018

Godot version:
e62e7fd

Issue description:
Several parts of my UI/menu screens are now placed/sized incorrectly.
In most cases it appears to be containers being sized as if they have no contents, but I'm not sure at the moment.

Similar problems can be seen in a couple of places in the editor UI:

In the project settings, the first time you select a property with a horizontal slider, the slider appears lower down. Reselecting it will put the slider in the right place.
project_properties

On the Help->About screen, the details do not appear on the first three tabs (Authors, Donors and License) until the tab is visited a second time. I suspect part of the UI is being sized as if it was empty.
The content of the Thirdparty License tab overflows its parent the first time it's viewed:
about_page_overflow

The smallest related example I've found so far is Popup.popup_centered() will position the popup incorrectly the first time. The top left of the popup will be in the center of the screen.
See example project below:

Minimal reproduction project:
gui_testing.zip
Press 'p' for the popup. Note the first time it appears it is not correctly centered.

@TailyFair
Copy link
Contributor

TailyFair commented May 16, 2018

Also:
something wrong

It only resizes properly when pop-up is dragged.

@volzhs
Copy link
Contributor

volzhs commented May 16, 2018

it seems regression from 005b69c

Changed UI resizing code, gained huge amount of speed.

cc @reduz

@akien-mga akien-mga added this to the 3.1 milestone May 16, 2018
@maikramer
Copy link

maikramer commented May 16, 2018

Amazing job anyway Juan, but, no resize at all here, sorry:
captura de tela de 2018-05-16 17-37-50

@ibrahn
Copy link
Contributor Author

ibrahn commented May 18, 2018

3b1ea51 seems to be involved too, at least for the about screen.
It somehow causes the Tree and RichTextLabel on the third party tab to be sized without respect to the size of their container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants