Button flashing "hover" style after releasing away from it

[MatthewJulian]

Godot version: 3.1.1 Stable

OS/device including version: Windows 10

Issue description: When you click off of a button (like when you change your mind), the button "flashes". I couldn't figure it out, but finally discovered that it looks like it's reporting as being "hovered" for a frame (or two). This doesn't really make sense, as it's not being hovered, and it looks weird when it flashes.
Here is a gif

Steps to reproduce: Use a button, click and hold, release outside of button. It'll flash

Minimal reproduction project:
ButtonProblem.zip

[MatthewJulian]

Along with the above problems, the is_hovered() method returns true on the frame you let go (it shouldn't).
I assume this is a pretty easy fix for anyone familiar with the engine and how the GUI works. I couldn't figure it out in the engine, but I have a workaround I'm using with GDscript (it's not pretty though)

Thanks

[Calinou]

@MatthewJulian Can you post the code for the workaround here, please? 🙂

[MatthewJulian]

Sure, here's what I'm currently doing on my TextureButtons:

extends Node2D
const normal := preload("res://normal.png")
const hover := preload("res://hover.png")

func _on_TextureButton_button_up() -> void:
	if !$TextureButton.get_rect().has_point(get_local_mouse_position()):
		$TextureButton.texture_hover = normal

func _on_TextureButton_mouse_entered() -> void:
	if $TextureButton.texture_hover != hover:
		$TextureButton.texture_hover = hover

So it changes the hover texture only when you release OUTSIDE of the button (that way, pressing it normally inside the button doesn't change). Then it just changes back to hover when your mouse enters it.

I was hesitant to post it because it's not really elegant, and also I don't know if changing the textures has a performance impact. (I assume it's just a matter of changing references, but you never know)

Also, and most importantly, this workaround doesn't address the underlying problem, which is that the internal state is_hovered() returns true when it shouldn't.