Fixes button flashing when releasing mousebutton outside #34781
Merged
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fossegutten
force-pushed
the
button-flash
branch
3 times, most recently
from
7a6793f to
6c6a640
Compare
akien-mga
reviewed
Jan 3, 2020
fossegutten
force-pushed
the
button-flash
branch
from
6c6a640 to
b728d3b
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33553
Buttons had status.hovering kept as true for two frames, after releasing mouse button outside of the button node. Because it takes a couple of frames for NOTIFICATION_MOUSE_EXIT to get sent after releasing mousebutton outside button.
Edit 3: Sorry, did a couple of edits to improve the commit. Squashed a commit too many. Think i fixed it now! 🤣