Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a context menu when right-clicking a file in the shader editor #75061

Closed
viktor-ferenczi opened this issue Mar 18, 2023 · 3 comments
Closed

Comments

@viktor-ferenczi
Copy link
Contributor

viktor-ferenczi commented Mar 18, 2023

Godot version

4.0 stable, 4.1 master

System information

Win 11, Vulcan

Issue description

I cannot find any Close or Close All menu items and right clicking on the shader's name in the open shaders list does not do anything, no context menu appears.

Pressing the "Script Editor / Close" shortcut (Ctrl-W) does not do anything on shader editors either. There is no separate shortcut for shader editors.

Right now one must restart Godot to close all shader windows before deleting or renaming them.

Related: #72595

Steps to reproduce

  1. Open any .gdshader or .gdshaderinc
  2. Try to close the shader editor

Minimal reproduction project

Any project with shader code.

@bitsawer
Copy link
Member

bitsawer commented Mar 18, 2023

You can select "File -> Close File" to close the currently open shader file and press the "Shader Editor" button to toggle the whole editor visibility (but I think you know this one). I agree that the shader editor should receive some usability improvements, including keyboard shortcuts and maybe mouse right-click context menu for the shader listing etc. Also slightly usability related: godotengine/godot-proposals#6355

editor

@KoBeWi
Copy link
Member

KoBeWi commented Mar 18, 2023

You can also close using middle click.

@Calinou Calinou changed the title There is no way to close shader editors Add a context menu when right-clicking a file in the shader editor Mar 19, 2023
@viktor-ferenczi
Copy link
Contributor Author

Thank you. I was blind. Most likely because the File menu is separate from the rest of menus over the editor, which is logical, but unusual.

@viktor-ferenczi viktor-ferenczi closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants