Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a context menu for the shader editor file list #95738

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

SomeRanDev
Copy link
Contributor

@SomeRanDev SomeRanDev commented Aug 18, 2024

I frequently right-click on items in the shader editor expecting a context menu like the script editor, and it's very jarring when nothing happens. This adds a basic context menu with the same structure as the one from the script editor; it includes a couple new options like "Close Other Tabs", "Close All", and "Show in File System."

Relevant issue: #75061

Godot Shader Editor Context Menu

@SomeRanDev SomeRanDev requested a review from a team as a code owner August 18, 2024 07:22
@Chaosus Chaosus added this to the 4.4 milestone Aug 18, 2024
@jsjtxietian
Copy link
Contributor

I think this can be merged along with #84063, to make the shader editor's usability better

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. Code looks good to me. Great work 🙂

shader_editor_context_menu.mp4

It might be worth adding "Close Tabs Below" in a future PR, but it's not essential for now.

@SomeRanDev
Copy link
Contributor Author

Noted! 👌

I'll also do a PR for "Sort". It was originally going to be part of this, but I decided to stick with the bare essentials for the initial context menu.

@akien-mga
Copy link
Member

Needs rebase (probably due to #84063).

@akien-mga akien-mga changed the title Add a Context Menu for the Shader Editor File List Add a context menu for the shader editor file list Aug 26, 2024
@SomeRanDev SomeRanDev force-pushed the shader_editor_context_menu branch from bcd2f55 to 34949d4 Compare August 27, 2024 00:37
@SomeRanDev SomeRanDev force-pushed the shader_editor_context_menu branch from 34949d4 to 8a087c7 Compare August 27, 2024 05:27
@SomeRanDev
Copy link
Contributor Author

Rebased and ready to go (after checks)! 👍

@akien-mga akien-mga merged commit 1b29f8b into godotengine:master Aug 27, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants