Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ctrl+s in text shader editor to save shader file will save the above scene too #84039

Closed
jsjtxietian opened this issue Oct 27, 2023 · 0 comments · Fixed by #84064
Closed

Use ctrl+s in text shader editor to save shader file will save the above scene too #84039

jsjtxietian opened this issue Oct 27, 2023 · 0 comments · Fixed by #84064
Labels
bug topic:editor topic:input
Milestone
4.2

Comments

@jsjtxietian
Copy link
Contributor

Godot version

Godot v4.2.beta (ea0ab44)

System information

  • Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 (NVIDIA; 31.0.15.3619) - 11th Gen Intel(R) Core(TM) i7-11700K @ 3.60GHz (16 Threads)

Issue description

When I write some shader in text shader editor, press Ctrl + S will not only save the shader file, but also save the opened scene.

Without an open scene it will show this :
image

Use File->Save file will not trigger the scene to be saved.

Steps to reproduce

  1. Open a new project, create a new scene and do some changes but don't save it.
  2. Create a test shader and edit it.
  3. Press ctrl s when the focus is at shader editor and observe the scene is also saved.

Minimal reproduction project

N/A
This was referenced Oct 27, 2023
Merged
Merged
@akien-mga akien-mga added this to the 4.2 milestone Oct 28, 2023
@jsjtxietian jsjtxietian mentioned this issue Nov 8, 2023
Closed
@reduz reduz mentioned this issue Nov 8, 2023
Closed
reduz added a commit to reduz/godot that referenced this issue Nov 14, 2023
@reduz
Save scene together with script/shader when ctrl-s is pressed.
4a34c24 
Fixes godotengine#84601.

The scene will also silently be saved (just like before), since many users
are not necessarily aware that the script or shader editor editors are focused
at the time of saving. Now, however, if something causes the save to fail it
will not be notified to the user, in case the user to avoid the annoyance
caused by godotengine#84039.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:editor topic:input
Projects
None yet
Milestone
4.2
Development

Successfully merging a pull request may close this issue.

Add save shortcut for text shader editor to prevent it propagating to scene jsjtxietian/godot
3 participants
@KoBeWi @akien-mga @jsjtxietian