Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Editor: Loading indicator is not visible in compatibility renderer #98019

Open
shahriarlabib000 opened this issue Oct 9, 2024 · 15 comments

Comments

@shahriarlabib000
Copy link
Contributor

shahriarlabib000 commented Oct 9, 2024

Tested versions

  • Reproducible in 4.4.dev2, 4.4.dev3, 4.4.beta1

System information

Godot v4.4.dev3 - Android - Single-window, 1 monitor - OpenGL ES 3 (Compatibility) - Mali-G52 - (8 threads)

Issue description

AFAIK there was a loading indicator. The loading screen when exporting from the Android Editor seems to be missing same for when installing Export template. It feels like the Editor is unresponsive without the loading indicator

lv_0_20241009192354.mp4

Steps to reproduce

Just export anything project from the Android Editor

Minimal reproduction project (MRP)

N/A

@llama-nl
Copy link

llama-nl commented Oct 9, 2024

Probably this is because of your device hardware.

@shahriarlabib000
Copy link
Contributor Author

Could be but i think I saw the loading indicator in some version of godot, can't remember which one tho

@shahriarlabib000
Copy link
Contributor Author

This isn't a problem in mobile renderer for some reason

@shahriarlabib000 shahriarlabib000 changed the title [Android Editor] export loading indicator is missing [Android Editor and compatibility renderer] export loading indicator is missing Nov 11, 2024
@syntaxerror247 syntaxerror247 modified the milestones: 4.x, 4.4 Jan 20, 2025
@syntaxerror247 syntaxerror247 moved this from Unassessed to Very Bad in 4.x Release Blockers Jan 20, 2025
@syntaxerror247
Copy link
Member

I can reproduce this in 4.4.beta1

@shahriarlabib000 Can you please confirm this is a regression by trying older versions?

@shahriarlabib000
Copy link
Contributor Author

@shahriarlabib000 Can you please confirm this is a regression by trying older versions?

I don't think it's a regression. Reproducible in 4.4.dev2 when #93526 was added.

@llama-nl
Copy link

@syntaxerror247 I don't think it is a Device pesific. As far as I know Compatibility Renderer has not loading screen, but Mobile Renderer has.

@syntaxerror247
Copy link
Member

@syntaxerror247 I don't think it is a Device pesific. As far as I know Compatibility Renderer has not loading screen, but Mobile Renderer has.

I can reproduce this issue with the Mobile Renderer as well.

Based on my current tests:

  • Compatibility Renderer: The progress bar is not visible for any loading tasks.
  • Mobile Renderer: The progress bar is visible for editor loading, imports, and other tasks, but it does not appear for exporting or loading export templates.

@shahriarlabib000
Copy link
Contributor Author

Mobile Renderer

4.4dev7.mp4
4.4.beta1.mp4

@shahriarlabib000
Copy link
Contributor Author

shahriarlabib000 commented Jan 20, 2025

So in mobile renderer it seems to be a regression from 4.4.dev7

@syntaxerror247
Copy link
Member

I suspect this issue is due to #99844
@shahriarlabib000 Can you test after reverting this PR?

@shahriarlabib000
Copy link
Contributor Author

I suspect this issue is due to #99844 @shahriarlabib000 Can you test after reverting this PR?

Yep reverting that PR fixed the issue in Mobile Renderer.

To clarify the issue still stays in compatibility Renderer

@syntaxerror247
Copy link
Member

syntaxerror247 commented Jan 20, 2025

@KoBeWi Can you please take a look at this issue?

Previously, it was only present in the Compatibility Renderer, but after your PR #99844, it's now present with the Mobile Renderer as well.

@KoBeWi
Copy link
Member

KoBeWi commented Jan 21, 2025

I can't reproduce it on Windows and I don't know what could be causing it. Do you see progress dialog when e.g. saving? The dialog will appear over currently focused Window, maybe it's not determined properly on Android. Try moving the dialog off the center (if possible); if progress appears, it will be behind the dialog.

@shahriarlabib000
Copy link
Contributor Author

if progress appears, it will be behind the dialog.

Yep,

Image

@syntaxerror247
Copy link
Member

syntaxerror247 commented Jan 22, 2025

@KoBeWi Android Editor runs in single window mode. It must be a problem with that.

Edit: I just tested it, Issue is also reproducible with Desktop Editor in single window mode.

@syntaxerror247 syntaxerror247 changed the title [Android Editor and compatibility renderer] export loading indicator is missing Android Editor: Loading indicator is not visible in compatibility renderer Jan 28, 2025
@AThousandShips AThousandShips modified the milestones: 4.4, 4.5 Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants