Fix progress dialog steals focus

[KoBeWi]

Same as #97009, but I made the dialog appear on currently focused window.

Fixes #96994
Fixes #90944

[JekSun97]

I sometimes see window focus issues when opening a project, is it possible to carry this over to importing a project?

[KoBeWi]

Yes, it's already included.

[Hilderin]

I'm using this PR for the last couple of days and it works great so far. It's very nice to be able to import assets in the background without Godot stealing the focus.

The only issue so far is the "Export Project..." button in the Export window. I need to do it twice for the exportation to run. Also, if I press only one time, select the file and close the window, the next time the Export window is opened, the exportation is executed.

[KoBeWi]

Should be fixed now, although I had to modify EditorFileDialog to emit file_selected before hiding. This might break some code.

[Hilderin]

Should be fixed now, although I had to modify EditorFileDialog to emit file_selected before hiding. This might break some code.

I'm really worry about this modification, that means that the editor file dialog will still be opened when saving a scene or when opening almost anything in the editor.

Just to be sure, I reverted locally the modifications in ProjectExportDialog and everything seems to work fine. What was the problem you encountered in this particular popup exactly?

[KoBeWi]

The file dialog did not return focus to export dialog and so the progress was appearing above the hidden file dialog, instead of the export dialog. Tested on Windows.

[KoBeWi]

Ok I reverted the EditorExport/FileDialog changes. The issue I had before doesn't seem to be happening anymore.

[akien-mga]

How does this work if you're trying to press the Cancel button of ProgressDialog with key events?

[KoBeWi]

Looks like you can't.
However canceling was broken before (at least during export: #93481) and now you can cancel with mouse, so it's still an improvement.

[Hilderin]

It's working when the ProgressDialog is not in another popup because the progress dialog is parented to the root and not the EditorNode. I guess a possible fix could be to accept space and enter key in EditorNode::input. The set_input_as_handled is really only used for shortcuts.

[Hilderin]

I detected another wierd side effect. When a sub scene is used in a main scene and both scenes are opened, when switching back to the main scene, the progress "Updating scene" appears and after that the first right click displays and context menu of the scene tab. My guess is that get_tree()->get_root()->set_input_as_handled(); causes the focus out of the scene tab from being triggered.
I tested on Godot master without this PR and I'm not able to reproduce.

godot.windows.editor.x86_64_wcKb0h8kXG.mp4

[KoBeWi]

No idea what causes it. Hiding the dialog and removing all input/processing overrides does not fix the issue. It's like it's caused by the existence of the dialog alone.

[Hilderin]

The issue is caused because Viewport::_gui_input_event does not process the button release and gui.mouse_focus is never reset to null.
I'm not sure why, but when I comment the line DisplayServer::get_singleton()->process_events(); in ProgressDialog::_update_ui is issue is fixed. Is that line still needed? I'm not sure but this line seems to drop events.

[KoBeWi]

It's part of the code that manually processes SceneTree. It's probably supposed to keep the dialog responsive and allow to cancel during processing.
...Except it doesn't work. I don't know what changed, but #93481 stays unresolved (it was being fixed in my previous tests).

I'll just remove this line.

[Hilderin]

Nice, it fixes the issue. I'll continue working in Godot using this PR to see if I spot other side effects.

[Hilderin]

Unfortunately, the last modification brings a "semi-bad" side effect. The editor window is unresponsive while the progress dialog is displayed. I retested after readding the DisplayServer::get_singleton()->process_events(); and the editor is responsive with the line.

[Hilderin]

Ok, I found a workaround... The issue is that gui.mouse_focus is still set in the ViewPort. I saw that there's a private method: Viewport::_drop_mouse_focus() that resets it.
And Viewport::_drop_mouse_focus() is called in set_disable_input.

So adding these lines in ProgressDialog::_popup fixes the issue of the right click after the save of a used scene and changing to the main scene:

...
reparent(current_window);

bool window_is_input_disabled = current_window->is_input_disabled();
current_window->set_disable_input(!window_is_input_disabled);
current_window->set_disable_input(window_is_input_disabled);

show();

Note that there's probably a more elegant way to fix the issue but it works.

[akien-mga]

Thanks!