Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON files produce *.uid files #99514

Closed
produno opened this issue Nov 21, 2024 · 3 comments · Fixed by #99540
Closed

JSON files produce *.uid files #99514

produno opened this issue Nov 21, 2024 · 3 comments · Fixed by #99540

Comments

@produno
Copy link

produno commented Nov 21, 2024

Tested versions

Godot 4.4 dev 5.

System information

Godot v4.4.dev5 - Windows 10.0.22631 - Single-window, 2 monitors - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4090 (NVIDIA; 32.0.15.6614) - 13th Gen Intel(R) Core(TM) i7-13700K (24 threads)

Issue description

I use JSON files for mod support and these get imported when starting up the game. However, it's creating uid's for all of these files and will not load due to errors.

eg:
Expected 'true','false' or 'null', got 'uid'. in res://Scenarios/Scenario_1.json.uid at line 0.

I'm not entirely sure if this is a bug but it seems to be an oversight. As now i will need to write extra code to handle this and all my mod files will be cluttered.

I did go through and remove them all and whilst the game will actually load, it takes several minutes longer than it should.

Steps to reproduce

Have JSON files within your game files and they will all be given a uid.

Minimal reproduction project (MRP)

N/A

@KoBeWi
Copy link
Member

KoBeWi commented Nov 22, 2024

JSON files are Resources since #65295, so this is expected.

@produno
Copy link
Author

produno commented Nov 29, 2024

JSON files are Resources since #65295, so this is expected.

Does this mean this will not be addressed? I see there is a linked pull request that still needs to be reviewed.

@KoBeWi
Copy link
Member

KoBeWi commented Nov 29, 2024

Does this mean this will not be addressed?

Not necessarily.

@adamscott adamscott changed the title uid's for JSON files? JSON files produce *.uid files Nov 30, 2024
@akien-mga akien-mga moved this from Immediate Blocker to Release Blocker in 4.x Release Blockers Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Release Blocker
Development

Successfully merging a pull request may close this issue.

3 participants