Core: Do not generate *.uid files for JSON, certificates, and translations

[dalexeev]

• Fixes JSON files produce *.uid files #99514.

[dalexeev]

Note that both overrides are required. This may seem odd, since in fact JSON does not have a UID. But we define "support" for custom UID... which is invalid. It might make sense to separate these three lines with a blank line for better readability.

godot/core/io/resource_loader.cpp

Lines 115 to 126 in f952bfe

	ResourceUID::ID ResourceFormatLoader::get_resource_uid(const String &p_path) const {
	int64_t uid = ResourceUID::INVALID_ID;
	if (has_custom_uid_support()) {
	GDVIRTUAL_CALL(_get_resource_uid, p_path, uid);
	} else {
	Ref<FileAccess> file = FileAccess::open(p_path + ".uid", FileAccess::READ);
	if (file.is_valid()) {
	uid = ResourceUID::get_singleton()->text_to_id(file->get_line());
	}
	}
	return uid;
	}

godot/editor/editor_node.cpp

Lines 1457 to 1465 in f952bfe

	void EditorNode::ensure_uid_file(const String &p_new_resource_path) {
	if (ResourceLoader::exists(p_new_resource_path) && !ResourceLoader::has_custom_uid_support(p_new_resource_path) && !FileAccess::exists(p_new_resource_path + ".uid")) {
	Ref<FileAccess> f = FileAccess::open(p_new_resource_path + ".uid", FileAccess::WRITE);
	if (f.is_valid()) {
	const ResourceUID::ID id = ResourceUID::get_singleton()->create_id();
	f->store_line(ResourceUID::get_singleton()->id_to_text(id));
	}
	}
	}

godot/editor/editor_file_system.cpp

Lines 1263 to 1270 in f952bfe

	if (fi->uid == ResourceUID::INVALID_ID && ResourceLoader::exists(path) && !ResourceLoader::has_custom_uid_support(path) && !FileAccess::exists(path + ".uid")) {
	// Create a UID.
	Ref<FileAccess> f = FileAccess::open(path + ".uid", FileAccess::WRITE);
	if (f.is_valid()) {
	fi->uid = ResourceUID::get_singleton()->create_id();
	f->store_line(ResourceUID::get_singleton()->id_to_text(fi->uid));
	}
	}

[KoBeWi]

We could make it into a macro called DISABLE_UID or something. These 2 lines will be the same for every class.

[dalexeev]

I think this is redundant for now. But we may reconsider this in the future if more exceptions are added.

[dalexeev]

I checked all ResourceFormatLoaders. Scripts, shaders, media files and other Godot files (*.gdextension) obviously need to have UIDs. But I found two potential candidates for which it might make sense to disable UIDs:

• ResourceFormatLoaderCrypto (*.crt, *.key, *.pub);
• TranslationLoaderPO (*.po, *.mo).

[akien-mga]

• ResourceFormatLoaderCrypto (*.crt, *.key, *.pub);
• TranslationLoaderPO (*.po, *.mo).

Yeah I think disabling .uid files for those would make sense.

We can always re-assess if some users report issues due to not having UIDs for those or .json, but I think it's better to start conservative (less intrusive to user projects) and adjust later.

[akien-mga]

Makes sense to me.

[Repiteo]

Thanks!