Custom tooltip showing when no tooltip text is set

[filkata]

Tested versions

Reproducible in 4.4-dev5, 4.4-dev4
Not reproducible in 4.4-dev3, 4.3 stable

System information

Godot v4.4.dev3 - Windows 10.0.19045 - Multi-window, 2 monitors - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 (NVIDIA; 32.0.15.6094) - AMD Ryzen 5 1500X Quad-Core Processor (8 threads)

Issue description

Previously if a node had a custom tooltip setup using _make_custom_tooltip() but has no tooltip text set -> no tooltip would be shown. In 4.4-dev4 and 4.4-dev5 an empty tooltip is shown.

Steps to reproduce

Hover over the TextureButton in the MRP.

Minimal reproduction project (MRP)

tooltip_bug.zip

[timothyqiu]

This is an intended change, see #97961.

Now _make_custom_tooltip() takes full control of the tooltip logic and is called regardless of whether get_tooltip() returns an empty string.

To obtain the old behavior, check the argument at the beginning of _make_custom_tooltip() and return null if it's an empty string.

[Mickeon]

While this is intentional, should not be denoted as a somewhat breaking change?

[filkata]

I wonder if this warrants a mention in the documentation?

[timothyqiu]

While this is intentional, should not be denoted as a somewhat breaking change?

Indeed. How should this be denoted?

[Mickeon]

First of all, I think we should tag the original PR as breaking compatibility(???). So that, when it's time, a page like Upgrading from Godot 4.2 to 4.3 can include this change, as well, without having to manually remember everything.