Allow Control
to show custom tooltip when tooltip text is empty
#97961
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97944
Fixes #97990
In #97397, I changed the implementation of button's
shortcut_in_tooltip
from overridingget_tooltip()
to overridingmake_custom_tooltip()
. However, if a button only has shortcut and no actual tooltip text, then the viewport assumes that the tooltip is not needed andmake_custom_tooltip()
is no longer called.This PR makes the tooltip displayed when the tooltip text is not empty or
make_custom_tooltip()
returns a valid control.This is useful when you want to make a customized tooltip without meaningful tooltip text.