Increase the size of the uniform set cache to 4096 to avoid cache thrashing from projects with high numbers of unique textures #100001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartcarnie
approved these changes
Dec 4, 2024
Oops, forgot to run doctool in my rush to claim 100001 |
Repiteo
approved these changes
Dec 5, 2024
…ashing from projects with high numbers of unique textures.
clayjohn
force-pushed
the
rd-uniform-set-cache
branch
from
8049b2e to
2535423
Compare
|
Should be good now! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the part of the performance regression that I was able to reproduce in #99420. More investigation is needed to find out why the OP is still seeing a performance regression.
CC @stuartcarnie