Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a very slight grammatical issue #100002

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

wyvrtn
Copy link
Contributor

@wyvrtn wyvrtn commented Dec 4, 2024

Changed the incorrect verb "have" into its correct form, "has." Fixes #99972

DANG IT SOMEONE TOOK MY 100,000th contrib

@wyvrtn wyvrtn requested a review from a team as a code owner December 4, 2024 01:34
@clayjohn clayjohn modified the milestones: 4.x, 4.4 Dec 4, 2024
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same typo exists in many other files with the same description, which should be fixed too:

doc/classes/PackedInt64Array.xml
190:                            Returns a copy of the data converted to a [PackedByteArray], where each element have been encoded as 8 bytes.

doc/classes/PackedInt32Array.xml
189:                            Returns a copy of the data converted to a [PackedByteArray], where each element have been encoded as 4 bytes.

doc/classes/PackedFloat32Array.xml
195:                            Returns a copy of the data converted to a [PackedByteArray], where each element have been encoded as 4 bytes.

doc/classes/PackedFloat64Array.xml
196:                            Returns a copy of the data converted to a [PackedByteArray], where each element have been encoded as 8 bytes.

And also spotted this one with a quick regex search:

doc/classes/SurfaceTool.xml
150:                            Generates a tangent vector for each vertex. Requires that each vertex have UVs and normals set already (see [method generate_normals]).

@wyvrtn
Copy link
Contributor Author

wyvrtn commented Dec 4, 2024

On it sire

@akien-mga
Copy link
Member

Looks good! To match our workflow, the commits would need to be squashed (see PR workflow for instructions).

I'm happy to do it myself if you're not familiar with this process and it looks overwhelming (it can be, initially :D).

@wyvrtn
Copy link
Contributor Author

wyvrtn commented Dec 4, 2024

Looks good! To match our workflow, the commits would need to be squashed (see PR workflow for instructions).

I'm happy to do it myself if you're not familiar with this process and it looks overwhelming (it can be, initially :D).

Sire, I've squashed the commits. First time I've ever used rebase in fact.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@wyvrtn wyvrtn requested review from a team as code owners December 5, 2024 14:06
Changed the incorrect verb "have" into its correct form, "has."
Fixes godotengine#99972

Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
@Repiteo Repiteo merged commit a27d744 into godotengine:master Dec 5, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 5, 2024

Thanks! Congratulations on your first merged contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Very slight grammatical issue in documentation
5 participants