-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a very slight grammatical issue #100002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same typo exists in many other files with the same description, which should be fixed too:
doc/classes/PackedInt64Array.xml
190: Returns a copy of the data converted to a [PackedByteArray], where each element have been encoded as 8 bytes.
doc/classes/PackedInt32Array.xml
189: Returns a copy of the data converted to a [PackedByteArray], where each element have been encoded as 4 bytes.
doc/classes/PackedFloat32Array.xml
195: Returns a copy of the data converted to a [PackedByteArray], where each element have been encoded as 4 bytes.
doc/classes/PackedFloat64Array.xml
196: Returns a copy of the data converted to a [PackedByteArray], where each element have been encoded as 8 bytes.
And also spotted this one with a quick regex search:
doc/classes/SurfaceTool.xml
150: Generates a tangent vector for each vertex. Requires that each vertex have UVs and normals set already (see [method generate_normals]).
On it sire |
Looks good! To match our workflow, the commits would need to be squashed (see PR workflow for instructions). I'm happy to do it myself if you're not familiar with this process and it looks overwhelming (it can be, initially :D). |
Sire, I've squashed the commits. First time I've ever used rebase in fact. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Changed the incorrect verb "have" into its correct form, "has." Fixes godotengine#99972 Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Thanks! Congratulations on your first merged contribution! 🎉 |
Changed the incorrect verb "have" into its correct form, "has." Fixes #99972
DANG IT SOMEONE TOOK MY 100,000th contrib