Core: Avoid including modules/modules_enabled.gen.h
in headers
#100023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
modules/modules_enabled.gen.h
regenerates anytime a module is changed, this causes all files with this header to necessitate a rebuild. For definition files this is generally fine, but header files can cause cascading recompilations across dozens, if not hundreds, of unnecessary files. Taking the test format from #99302, the refactors from this PR resulted in:Results