Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI inconsistencies in EditorFileDialog's toolbar #100027

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

timothyqiu
Copy link
Member

  1. Sort button has different stylebox compared to others
Before After
button-style-before button-style-after
  1. The top toolbar has a separator on the right side when in open mode
Save Mode Open Mode Before Open Mode After
toolbar-save toolbar-before toolbar-after
  1. Update fav up/down buttons when fav list changes

@timothyqiu timothyqiu added this to the 4.x milestone Dec 5, 2024
@timothyqiu timothyqiu requested review from a team as code owners December 5, 2024 00:39
- Sort button has different stylebox compared to others
- The top toolbar has a separator on the right side when in open mode
- Update fav up/down buttons when fav list changes
@akien-mga akien-mga modified the milestones: 4.x, 4.4 Dec 5, 2024
@adamscott adamscott changed the title Fix UI inconsistencies in EditorFileDialog's toolbar Fix UI inconsistencies in EditorFileDialog's toolbar Dec 5, 2024
@Repiteo Repiteo merged commit 68cd7f2 into godotengine:master Dec 5, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 5, 2024

Thanks!

@timothyqiu timothyqiu deleted the efd-improve branch December 5, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants