Add missing GDVIRTUAL_BIND() for AudioStream::_has_loop() and ::_get_bar_beats()
#100126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamscott
approved these changes
Dec 6, 2024
Mickeon
reviewed
Dec 7, 2024
…_get_bar_beats()`
dsnopek
force-pushed
the
gdextension-missing-gdvirtual-bind
branch
from
e443f64 to
3866a7f
Compare
Bromeon
approved these changes
Dec 8, 2024
|
Thanks! |
dsnopek
added
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #99933, @Bromeon noticed that there were some
GDVIRTUAL_CALL()'s that didn't have correspondingGDVIRTUAL_BIND()'s registering the virtual methods.This PR adds them!
I'm at a little bit of a loss with regard to the documentation, because I don't really know what the data returned from these virtual methods means, so if anyone knows, please let me know and I'll update it! Otherwise, having something in the docs is better than having the methods missing entirely :-)