Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thorvg: Regenerate and apply patches #100140

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

Chubercik
Copy link
Contributor

When updating thorvg to version 0.15.5 (#100008) I omitted (by mistake) applying Godot's patches - this PR fixes that oversight:

  • I added an entry in thirdparty/README.md to remind devs to apply patches during updates,
  • pr2740-renderer-crash-hotfix.patch is no longer needed due to the fix being merged upstream,
  • revert-tvgLines-bezier-precision-change.patch has been regenerated (due to code migrating from tvgLines.cpp to tvgMath.cpp) and re-applied.

@Chubercik Chubercik requested a review from a team as a code owner December 7, 2024 14:09
@Repiteo Repiteo merged commit 2256d6d into godotengine:master Dec 9, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 9, 2024

Thanks!

@Chubercik Chubercik deleted the thorvg_patches branch December 9, 2024 21:17
@Chubercik
Copy link
Contributor Author

Thank you and sorry for the mishap 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants