Don't duplicate custom type scripts

[KoBeWi]

Fixes #100154

[Synzorasize]

Hey, I just ran into this issue, so I decided to test out this commit and it works perfectly. I don't know much about C++ or the Godot source code or code style, though, but it looks good enough to me.

[sfreed141]

I tried this fix out since I was hitting #100154 in a personal project but it resulted in .duplicate(true) failing to make a deep copy. Not sure what's different about my code compared with Synzorasize, but replacing the .duplicate(true) with some code to manually copy my resource works fine.

Fwiw, I have nested custom resources so perhaps that's the issue: a custom resource AttributeSet which contains an array of another custom resource, AttributeResources. Calling attribute_set.duplicate(true) performs a shallow copy.

[KoBeWi]

Do you have the same issue in dev5? It might be another bug.

[sfreed141]

If I launch my project through the editor on dev4/5/6 I hit #100154. However if I run the project directly without the editor then I do still hit the duplicate bug (on dev4/5/6). So perhaps it is a different (but more severe) bug?

[adamscott]

Oops. Didn't see your PR when I did mine: #101001.

Mine seems to be forward-compatible with additional scripts as metadata though.

[adamscott]

@sfreed141 Can you test my fix #101001? It seems to solve #100154 with the latest builds.

[sfreed141]

@adamscott yes, your PR does fix #100154, however deep copying a resource is still broken unfortunately :(