-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[.NET] Upgrade user project's TargetFramework to net8.0
#100195
Conversation
41da5b5
to
861eccb
Compare
I'm not sure if it's an appropriate place to mention this, but the existing upgrade mechanism seems to removes the blank lines in csproj when updating, that is, the following csproj: <Project Sdk="Godot.NET.Sdk/4.3.0">
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<LangVersion>12</LangVersion>
<Nullable>enable</Nullable>
<EnableDynamicLoading>true</EnableDynamicLoading>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="GDTask" Version="1.3.0"/>
<PackageReference Include="gdUnit4.api" Version="4.3.1"/>
</ItemGroup>
</Project> will becomes this after the upgrade: <Project Sdk="Godot.NET.Sdk/4.4.0">
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<LangVersion>12</LangVersion>
<Nullable>enable</Nullable>
<EnableDynamicLoading>true</EnableDynamicLoading>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="GDTask" Version="1.3.0"/>
<PackageReference Include="gdUnit4.api" Version="4.3.1"/>
</ItemGroup>
</Project> |
861eccb
to
6107470
Compare
It's somewhat unrelated but an easy fix so I decided to include it. |
Needs rebase. For the record the 4.4-dev7 build is planned for Thursday, do you want this PR included by then, or do you prefer to wait for it to be merged right after, and then included in beta1 in January? |
- Upgrades the TFM for new created projects to `net8.0`. - Implements system to upgrade TFM for existing projects to `net8.0`.
6107470
to
8d41b5a
Compare
I would prefer to include it in 4.4-dev7 so it's in the same release that makes |
Thanks! |
net8.0
.net8.0
.